GLExtensions: remove NV_depth_buffer_float from OpenGL 3.0 #5063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regression introduced in e99cd57 / 4935: VideoBackends: Set the maximum range when the depth range is oversized[1]. The NV_depth_buffer_float extension is not part of OpenGL 3.0, and requiring it causes a hard crash when it's not supported (e.g. macOS). [1]: dolphin-emu#4935
|
Also, I wasn't aware this list indicated required extensions? If so, then that's my mistake and the proper fix is to remove it from the list, the extension is entirely optional. |
|
@Armada651 that list indicates presumed extensions, based on the OpenGL version, in case they're not returned by GL_EXTENSIONS. Any other extension can be queried and used specifically, as long as it's seen in GL_EXTENSIONS. |
|
SGTM |
CrossVR
approved these changes
Mar 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression introduced in e99cd57 / 4935: VideoBackends: Set the maximum range when the depth range is oversized. The NV_depth_buffer_float extension is not part of OpenGL 3.0, and requiring it causes a hard crash when it's not supported (e.g. macOS).