SI_DeviceGBA: Minor cleanup #5078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents truncation when assigning to this member in the constructor. This isn't size-critical code, so opting for the more straightforward assignment is fine here.
Prevents potential recompilation of other files if these ever need to change.
Prevents potential implicit construction scenarios involving ints.
%zu is the correct specifier for printing size_t.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a little cleanup. Each commit should be fairly self-explanatory.
I'll likely do this for other serial interface classes as well, however considering SI_DeviceGBA and SI_DeviceGCController are significantly larger than the others, I'd like to get those out of the way separately first (starting with SI_DeviceGBA).