MEGASignatureDB: Minor changes #5183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These functions aren't dependent on any database state and can be hidden.
Signatures during loading and strings during reference retrieval can be moved.
|
Could you also change the string in DolphinWX/MainMenuBar.cpp "Must use Generate Symbol Map first!" to "Must use Generate Symbols first!" since PR #5156 was merged, please. Otherwise, LGTM. |
Keeps it consistent with the regular signature DB option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed these when reading the diff from #5088 again (after the code was merged, I was too slow).