TASInputDlg: Minor changes #5196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
degasus
reviewed
Apr 2, 2017
| wxGridSizer* const buttons_grid = new wxGridSizer(4); | ||
| for (unsigned int i = 4; i < ArraySize(m_buttons); ++i) | ||
| auto* const buttons_grid = new wxGridSizer(4); | ||
| for (size_t i = 4; i < m_buttons.size(); ++i) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
degasus
reviewed
Apr 2, 2017
| wxGridSizer* const buttons_grid = new wxGridSizer(4); | ||
| for (unsigned int i = 4; i < ArraySize(m_buttons); ++i) | ||
| auto* const buttons_grid = new wxGridSizer(4); | ||
| for (size_t i = 4; i < m_buttons.size(); ++i) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
else LGTM |
sepalani
reviewed
Apr 2, 2017
Source/Core/DolphinWX/TASInputDlg.h
Outdated
| ID_CC_L_STICK = 1003, | ||
| ID_CC_R_STICK = 1004 | ||
| }; | ||
|
|
||
| int m_eleID = 1005; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
As all UI controls are essentially constructed with new expressions, the type is already visible on the right-hand side, so repeating the type twice isn't necessary.
wxCommandEvent already stores the necessary data; the control object itself doesn't need to be retrieved and casted.
wxQueueEvent/wxPostEvent are useful when the event is being dispatched to another separate window, but aren't really necessary when the event will be handled by the same window it's dispatched from. GetEventHandler() is unnecessary here for the same reason. It's an event intended to be handled by the dialog itself.
These are all related constants (and it doesn't make sense to allow taking the address of them).
Helios747
approved these changes
Apr 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just minor clean-up related things.