Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StringUtil: Fix a ctype assertion #5214

Merged
merged 1 commit into from Apr 8, 2017
Merged

StringUtil: Fix a ctype assertion #5214

merged 1 commit into from Apr 8, 2017

Conversation

sepalani
Copy link
Contributor

@sepalani sepalani commented Apr 6, 2017

This PR fixes a ctype assertion because isprint expects the value to fit in an unsigned char and get rid of an useless StringFromFormat.

Ready to be reviewed & merged.

BhaaLseN
BhaaLseN approved these changes Apr 6, 2017
View reviewed changes
Copy link
Member

@BhaaLseN BhaaLseN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I guess? Haven't tested it, but I'll trust the docs that this doesn't have any undefined behavior to it (unlike the other one which does for unsigned char)

@sepalani
Copy link
Contributor Author

sepalani commented Apr 6, 2017

It doesn't ;v) #4792

@BhaaLseN
Copy link
Member

BhaaLseN commented Apr 6, 2017

Oh, I knew I've seen this one before :D

@lioncash lioncash merged commit 9a7c280 into dolphin-emu:master Apr 8, 2017
@sepalani sepalani deleted the strutil-fix branch April 8, 2017 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lioncash lioncash lioncash approved these changes

@BhaaLseN BhaaLseN BhaaLseN approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@sepalani @BhaaLseN @lioncash