VideoConfigDiag: Move event implementations into the cpp file #5218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lioncash
force-pushed
the
video
branch
2 times, most recently
from
582ec63
to
b7b8c47
Compare
BhaaLseN
approved these changes
Apr 7, 2017
|
|
||
| void VideoConfigDiag::Event_Adapter(wxCommandEvent& ev) | ||
| { | ||
| // TODO |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Also removes the unused Event_Adapter event stub which did nothing. It wasn't even hooked up to wx's event system. Allows removing several includes from the header file and moving them to the cpp file. Prevents includes being dumped into other source files that include the header. This uncovered an indirect include in Main for MsgHandler utilities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows removing several includes from the header file and moving them to the cpp file. Prevents includes being dumped into other source files that include the header.