Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PPCTables: Do not consider OPTYPE_UNKNOWN as valid instruction #5239

Merged
merged 1 commit into from Apr 10, 2017
Merged

PPCTables: Do not consider OPTYPE_UNKNOWN as valid instruction #5239

merged 1 commit into from Apr 10, 2017

Conversation

sepalani
Copy link
Contributor

This PR prevents functions like FindFunctionsAfterBLR to consider the instruction 0x00000000 as valid and add weird functions.

Ready to be reviewed & merged.

@sepalani sepalani mentioned this pull request Apr 10, 2017
Merged
BhaaLseN
BhaaLseN approved these changes Apr 10, 2017
View reviewed changes
Copy link
Member

@BhaaLseN BhaaLseN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That does look like a weird oversight, good catch!

@lioncash lioncash merged commit ae80a75 into dolphin-emu:master Apr 10, 2017
@sepalani sepalani deleted the is-valid-instruction branch April 10, 2017 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lioncash lioncash lioncash approved these changes

@BhaaLseN BhaaLseN BhaaLseN approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@sepalani @lioncash @BhaaLseN