Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix display of Japanese text in the Memory Card Manager #5336

Merged
merged 1 commit into from Apr 30, 2017
Merged

Fix display of Japanese text in the Memory Card Manager #5336

merged 1 commit into from Apr 30, 2017

Conversation

JosJuice
Copy link
Member

Regression from PR #4566. When I was going to invert == 0, I changed it into == 1 instead of the correct != 0.

@spycrab
Copy link
Contributor

spycrab commented Apr 29, 2017

LGTM

leoetlino
leoetlino approved these changes Apr 29, 2017
View reviewed changes
Copy link
Member

@leoetlino leoetlino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would it be worth making that an enum so the check is more obvious and less error prone?

@JosJuice
Copy link
Member Author

I don't know enough about this to feel safe doing that. (Encoding was set to 256 for the memory card that was attached to https://bugs.dolphin-emu.org/issues/10247, but I don't know if Shift-JIS always uses 256.)

@lioncash lioncash merged commit 344767a into dolphin-emu:master Apr 30, 2017
@JosJuice JosJuice deleted the memcard-shiftjis branch May 1, 2017 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoetlino leoetlino leoetlino approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@JosJuice @spycrab @leoetlino @lioncash