Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation on Debian 8 with libavcodec #548

Closed
wants to merge 2 commits into from
Closed

Fix compilation on Debian 8 with libavcodec #548

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 3, 2014

Fixing https://code.google.com/p/dolphin-emu/issues/detail?id=7408
A new version of libavcodec was the problem.

I am a C and C++ beginner, so I might have introduced problems, so my code should be reviewed.
Thanks.

Spanti Nicola (RyDroid) added 2 commits July 3, 2014 00:56
…sie/testing with libavcodec.

I am a C and C++ beginner, so this commit MUST be checked, thanks.
…compilation-on-debian-8-with-libavcodec

Conflicts:
	Source/Core/VideoCommon/AVIDump.cpp
@ghost
Copy link
Author

ghost commented Jul 3, 2014

Oops, av_frame_alloc and avcodec_encode_video2 (at least 2011 and older) are probably not available in old libavcodec.
I will check with Debian 7 Wheezy in 1 or 2 days.

@Parlane
Copy link
Member

Parlane commented Jul 3, 2014

You shouldn't have merges like that in your pull requests. Use rebase, not merge.

@@ -171,7 +176,7 @@ void AVIDump::AddFrame(const u8* data, int w, int h)
if (m_totalBytes >= 2000000000)
{
CloseFile();
m_fileCount++;
++m_fileCount;

This comment was marked as off-topic.

@Tilka
Copy link
Member

Tilka commented Jul 3, 2014

@rydroid You can't just call avcodec_encode_video2() with nullptr as the last parameter, it's dereferenced without a check. Take a look at #362, the only thing missing is to work around CMake's cache.

@ghost ghost closed this Jul 3, 2014
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants