AVIDump: use new ffmpeg/libav API

[Tilka]

libav 10 has been released on May 10th, 2014 (it drops support for some
long-deprecated stuff).

Can someone test this on Debian unstable?

Problem: Debian stable only ships the new API in backports.

[Tilka]

Seems like our GitHub integration is still a bit buggy...

[pinumbernumber]

../Source/Core/VideoCommon/AVIDump.cpp: In static member function ‘static bool AVIDump::CreateFile()’:
../Source/Core/VideoCommon/AVIDump.cpp:263:24: error: ‘CODEC_ID_FFV1’ was not declared in this scope
g_Config.bUseFFV1 ?  CODEC_ID_FFV1 : s_FormatContext->oformat->video_codec;
                        ^
../Source/Core/VideoCommon/AVIDump.cpp: In static member function ‘static void AVIDump::CloseFile()’:
../Source/Core/VideoCommon/AVIDump.cpp:365:27: error: cannot convert ‘AVFrame*’ to ‘AVFrame**’ for argument ‘1’ to ‘void av_frame_free(AVFrame**)’
av_frame_free(s_BGRFrame);
                        ^
../Source/Core/VideoCommon/AVIDump.cpp:369:27: error: cannot convert ‘AVFrame*’ to ‘AVFrame**’ for argument ‘1’ to ‘void av_frame_free(AVFrame**)’
av_frame_free(s_YUVFrame);
                        ^
ninja: build stopped: subcommand failed.

Note that I'm a bit of a debian newbie, I might very well be doing something wrong

[Tilka]

@pinumbernumber: How about now?

[pinumbernumber]

@Tilka: Sorry for the delay, yes it builds now. Thanks for fixing it

[Tilka]

(Squashed.)

[Tilka]

Doesn't work yet, closing for now.

[delroth]

Reopening for buildbot test.

[delroth]

@dolphin-emu-bot rebuild

[shuffle2]

Er, was this reopened just to test the buildbot, and is not intended to be merged (ever)...or what?

[matthewharvey]

Is this going to be merged? The build is still broken for me on Debian Jessie.

[Tilka]

@matthewharvey: The problem is that it doesn't actually work, it only fixes the build.

Closing for now. I'll reopen when I have something that works.

[Tilka]

MPEG works now (FFV1 was already broken before).

[JMC47]

What's the status of the PR? There's a milestone current issue relying on it.

[Tilka]

@JMC47 FFV1 is still broken. Originally I thought I would somehow stumble upon a fix but that hasn't happened so far. This PR can be merged as it is. Getting compatible with libav 10 was my main concern.

[lioncash]

Could this be rebased to remove the merge commits and stuff from neobrain/magumagu/delroth, etc?

[Tilka]

@dolphin-emu-bot rebuild

(This should fail during CMake.)

[Tilka]

It actually does build correctly when there is no ffmpeg installed or when it's too old.

Please review/merge.

[lioncash]

@Tilka: This comment grants you the permission to merge this pull request whenever you think it is ready. After addressing the remaining comments, click this link to merge.

---

Looks good to me

@dolphin-emu-bot allowmerge