-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AVIDump: use new ffmpeg/libav API #362
Conversation
Seems like our GitHub integration is still a bit buggy... |
Note that I'm a bit of a debian newbie, I might very well be doing something wrong |
@pinumbernumber: How about now? |
@Tilka: Sorry for the delay, yes it builds now. Thanks for fixing it |
(Squashed.) |
Doesn't work yet, closing for now. |
Reopening for buildbot test. |
@dolphin-emu-bot rebuild |
Er, was this reopened just to test the buildbot, and is not intended to be merged (ever)...or what? |
Is this going to be merged? The build is still broken for me on Debian Jessie. |
@matthewharvey: The problem is that it doesn't actually work, it only fixes the build. Closing for now. I'll reopen when I have something that works. |
MPEG works now (FFV1 was already broken before). |
What's the status of the PR? There's a milestone current issue relying on it. |
@JMC47 FFV1 is still broken. Originally I thought I would somehow stumble upon a fix but that hasn't happened so far. This PR can be merged as it is. Getting compatible with libav 10 was my main concern. |
Could this be rebased to remove the merge commits and stuff from neobrain/magumagu/delroth, etc? |
libav 10 was released on May 10th, 2014 and it drops support for some long-deprecated stuff like avcodec_encode_video().
We support both.
@dolphin-emu-bot rebuild (This should fail during CMake.) |
It actually does build correctly when there is no ffmpeg installed or when it's too old. Please review/merge. |
@Tilka: This comment grants you the permission to merge this pull request whenever you think it is ready. After addressing the remaining comments, click this link to merge. Looks good to me @dolphin-emu-bot allowmerge |
AVIDump: use new ffmpeg/libav API
libav 10 has been released on May 10th, 2014 (it drops support for some
long-deprecated stuff).
Can someone test this on Debian unstable?
Problem: Debian stable only ships the new API in backports.