Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: enable same conformance-related flags as msbuild #5554

Merged
merged 1 commit into from Jun 6, 2017
Merged

cmake: enable same conformance-related flags as msbuild #5554

merged 1 commit into from Jun 6, 2017

Conversation

shuffle2
Copy link
Contributor

@shuffle2 shuffle2 commented Jun 6, 2017

replaces #5162

@shuffle2 shuffle2 mentioned this pull request Jun 6, 2017
Closed
@shuffle2 shuffle2 merged commit c34c0db into dolphin-emu:master Jun 6, 2017
@shuffle2 shuffle2 deleted the cmake-msvc-conformance branch June 6, 2017 07:56
@BhaaLseN
Copy link
Member

BhaaLseN commented Jun 6, 2017

Does it matter if /permissive- is set twice then? We kinda opted for "Source only, no Externals" and put it in Source/CMakeLists.txt back then.

@shuffle2
Copy link
Contributor Author

shuffle2 commented Jun 6, 2017

it doesn't really matter, cl will normally ignore all but the last instance of any duplicate flags it sees. In this case they are set to the same value, anyways. cmake may even do some filtering, idk. But it should still probably be cleaned up.

fwiw, /permissive just modifies /Zc flags (afaik). So also putting /Zc:rvalueCast, etc, here would have been duplication as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@shuffle2 @BhaaLseN