Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EditorConfig: Don't enforce a specific line ending #5561

Merged
merged 1 commit into from Jun 6, 2017

Conversation

bb010g
Copy link
Contributor

@bb010g bb010g commented Jun 6, 2017

Resolves the discussion in #5541.

Currently waiting on a confirmation that the presence/absence of insert_final_newline doesn't affect Visual Studio at all.

@BhaaLseN
Copy link
Member

BhaaLseN commented Jun 6, 2017

It doesnt. Some extensions apparently do support it (like, one of the Git extensions), but I never really checked those. The roslyn repositories include the setting as well, so I don't think any harm comes from leaving it in (especially as other editors/IDEs do support it, and will hopefully also use it)

@shuffle2 shuffle2 merged commit c9ba2b3 into dolphin-emu:master Jun 6, 2017
@bb010g bb010g deleted the editorconfig-endings branch June 7, 2017 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants