ESFormats additions and fixes #5601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
leoetlino
commented
Jun 12, 2017
leoetlino
commented
- Add a SignedBlobReader (base reader for signed blobs, like TMDs, tickets and certs) and move some of the common code into this base class.
- Add a CertReader and a cert chain parser that will be used by ES to verify containers.
leoetlino
force-pushed
the
esformats-additions
branch
from
5571fc8
to
e554238
Compare
|
Related idea but maybe not pertaining to the scope of this PR; use the new std::byte for |
lioncash
reviewed
Jun 12, 2017
|
|
||
| std::vector<u8> CertReader::GetPublicKey() const | ||
| { | ||
| static const std::map<SignatureType, std::pair<size_t, size_t>> type_to_key_info = {{ |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
@goldenercobra That'd be really outside of the scope of this PR, which is mostly code reorganisation + a new reader. |
leoetlino
force-pushed
the
esformats-additions
branch
3 times, most recently
from
bd7cc8a
to
9cd53ea
Compare
Allows common signature parsing code to not be duplicated.
The ES function that used to make use of it was changed to be more sane, so GetRawHeader() is now unused and useless.
This will be used to avoid duplicating cert chain parsing code.
On Windows, this would fail because the file handle wasn't closed.
leoetlino
force-pushed
the
esformats-additions
branch
from
9cd53ea
to
a370ad5
Compare
BhaaLseN
approved these changes
Jun 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.