Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gettextize: extract arguments to Qt's tr #5812

Merged
merged 2 commits into from Jul 23, 2017
Merged

gettextize: extract arguments to Qt's tr #5812

merged 2 commits into from Jul 23, 2017

Conversation

ligfx
Copy link
Contributor

@ligfx ligfx commented Jul 22, 2017

No description provided.

@ligfx
Copy link
Contributor Author

ligfx commented Jul 22, 2017

@JosJuice

@lioncash
Copy link
Member

IMO © is better typographically here. \u00A9 can be used instead if literals aren't desirable.

@ligfx
Copy link
Contributor Author

ligfx commented Jul 23, 2017

@lioncash done!

@leoetlino
Copy link
Member

Fwiw, xgettext has the --qt option:

--qt   recognize Qt format strings (only language C++)

@leoetlino
Copy link
Member

Never mind -- it doesn't do what you want. It just handles Qt's arg format strings and not tr.

@leoetlino leoetlino merged commit 55fb6ef into dolphin-emu:master Jul 23, 2017
lioncash
lioncash reviewed Jul 23, 2017
View reviewed changes
Source/Core/DolphinQt2/AboutDialog.cpp
@@ -54,8 +54,8 @@ AboutDialog::AboutDialog(QWidget* parent) : QDialog(parent)
text_label->setOpenExternalLinks(true);

QLabel* copyright =
new QLabel(tr("© 2003-%1 Dolphin Team. “GameCube” and “Wii” are"
" trademarks of Nintendo. Dolphin is not affiliated with Nintendo in any way.")
new QLabel(tr("\u00A9 2003-%1 Dolphin Team. \u201cGameCubeu201d and \u201cWiiu201d are "

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@ligfx ligfx mentioned this pull request Jul 23, 2017
Merged
@JosJuice JosJuice mentioned this pull request Jul 23, 2017
Merged
@leoetlino leoetlino modified the milestone: Qt Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lioncash lioncash lioncash left review comments

@leoetlino leoetlino leoetlino left review comments

Assignees
No one assigned
Labels
None yet
Milestone
Qt
3 participants
@ligfx @lioncash @leoetlino