DolphinQt2: Change the placement of "Use Built-In Database of Game Names" #5821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mes" When I added this setting, I didn't notice that the interface pane in DolphinQt2 was split into two different sections.
This one is my fault too
|
This TitleDatabase setting is definitely part of the UI setting. But what about "Show Active Title in Window Title"? Is that an in-game or UI setting? (It seems like both to me, in the same manner as panic handlers.) |
|
¯\_(ツ)_/¯ To be honest, I don't think this split makes much sense in general... Things like render to main and auto-adjusting the game window size only have an effect in-game. EDIT: Oh, now I get why it was like this. This is basically a split of things that were in the video config in DolphinWX and things that weren't, which doesn't seem like a good way to organize things. |
ligfx
approved these changes
Jul 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I added this setting, I didn't notice that the interface pane in DolphinQt2 was split into two different sections.