Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gcifolder use correct region for fifologs #589

Merged
merged 1 commit into from Jul 28, 2014

Conversation

LPFaint99
Copy link
Contributor

the region is not passed down to the exi level.
The checkmemcardpath sets the correct region earlier in the game startup, take advantage of this for now.

it would be nice to have the region passed down to exi level, but it seemed to be out of scope of this problem
the checkmemcardpath function may need to be refactored down to the exi level, but this would also require passing the region down

@lioncash
Copy link
Member

lioncash commented Jul 9, 2014

Looks good to me.

@@ -132,6 +132,25 @@ void CEXIMemoryCard::setupGciFolder(u16 sizeMb)
case DiscIO::IVolume::COUNTRY_USA:
strDirectoryName += USA_DIR DIR_SEP;
break;
case DiscIO::IVolume::COUNTRY_UNKNOWN:
{
// FIFO LOG, anything else?

This comment was marked as off-topic.

This comment was marked as off-topic.

@Parlane
Copy link
Member

Parlane commented Jul 23, 2014

Booto pointed out that this does not seem to handle EUR very nicely ?

@LPFaint99
Copy link
Contributor Author

Can you be more specific?
EUR falls through to the default case
On Jul 22, 2014 9:38 PM, "Matthew Parlane" notifications@github.com wrote:

Booto pointed out that this does not seem to handle EUR very nicely ?


Reply to this email directly or view it on GitHub
#589 (comment).

@Parlane
Copy link
Member

Parlane commented Jul 23, 2014

Oh god you rely on case fall through lol
Nvm then ;p

@lioncash
Copy link
Member

Is this OK to merge or are there still underlying issues?

@LPFaint99
Copy link
Contributor Author

Afaik it is ok to be merged
On Jul 25, 2014 5:50 AM, "Lioncash" notifications@github.com wrote:

Is this OK to merge or are there still underlying issues?


Reply to this email directly or view it on GitHub
#589 (comment).

neobrain added a commit that referenced this pull request Jul 28, 2014
Gcifolder use correct region for fifologs
@neobrain neobrain merged commit 3fb829c into dolphin-emu:master Jul 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants