Undefine wxHAS_XLOCALE_SUPPORT #5974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lioncash
reviewed
Aug 24, 2017
| #else | ||
| #undef wxHAS_XLOCALE_SUPPORT | ||
| #endif | ||
| /* This define is unused by dolphin. */ |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Thanks for the suggestion, it works for me and I have implemented it. |
|
As I don't use windows I am not sure what to do about the windows build fail? |
0x647262
reviewed
Aug 24, 2017
Externals/wxWidgets3/wx/wxmsw.h
Outdated
| @@ -465,7 +465,7 @@ | |||
| // | |||
| // Recommended setting: 1 but may be disabled if you are writing programs | |||
| // running only in C locale anyhow | |||
| #define wxUSE_XLOCALE 1 | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Changing it for windows is not really needed to work around a glibc issue in linux and as it does seem needed there so I changed it back. Maybe that will make the buildbot happy? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some system upgrades (glibc-2.26?) dolphin-emu will no longer build.
I am informed this part of wxWidgets is not used by dolphin and so rather than fixing the issue, its easier to just disable it here. I am not sure this is the ideal way of doing it, but it now builds again.