Fix the Android OpenGL About tab. #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lioncash care to review? |
|
Will review it when I get home. Phone is being weird and I can't view
|
|
@Sonicadvance1 Does logcat say anything about context creation failing on rotation? Not saying this code causes it, just being extra finicky. If it doesn't, then it looks fine to me. |
|
It does complain, this probably does cause it. May have to look in to it. |
| @@ -262,6 +268,7 @@ private boolean detect() | |||
| private void create(int width, int height, int renderableType) | |||
| { | |||
| int[] attribs = { | |||
| EGL10.EGL_RENDERABLE_TYPE, renderableType, | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Looks good to me. |
Move EGLHelper to be local to the creation of the about GL/GLES tabs so we don't have 3 EGL contexts running at a time. Fix issues with OpenGL context creation here so we show the correct information. This requires adding an EGL function to the NativeLibrary since Android's JAVA bindings don't expose eglBindAPI.
Sonicadvance1
added a commit
that referenced
this pull request
Feb 23, 2014
Fix the Android OpenGL About tab.
Techjar
pushed a commit
to Techjar/dolphin
that referenced
this pull request
Jan 30, 2022
Replace Backslash with forward-slash
ryanmcgrath
pushed a commit
to ryanmcgrath/dolphin
that referenced
this pull request
Feb 6, 2024
brings us up to 22642cc0c360af9b10c53592249927f04ebb6832 (for the most part) still needs playback fixed, adapter polling rate, and good config defaults
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move EGLHelper to be local to the creation of the about GL/GLES tabs so we don't have 3 EGL contexts running at a time.
Fix issues with OpenGL context creation here so we show the correct information.
This requires adding an EGL function to the NativeLibrary since Android's JAVA bindings don't expose eglBindAPI.