Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qt: Fix building on <= 5.7.x #6000

Merged
merged 1 commit into from Sep 2, 2017
Merged

Qt: Fix building on <= 5.7.x #6000

merged 1 commit into from Sep 2, 2017

Conversation

spycrab
Copy link
Contributor

@spycrab spycrab commented Sep 2, 2017

No description provided.

ligfx
ligfx approved these changes Sep 2, 2017
View reviewed changes
Copy link
Contributor

@ligfx ligfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it'd be better to remove the reliance on Qt here entirely and use std::chrono

@lioncash
Copy link
Member

lioncash commented Sep 2, 2017

@ligfx probably, if it's the more flexible option

lioncash
lioncash approved these changes Sep 2, 2017
View reviewed changes
Copy link
Member

@lioncash lioncash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That said, it can always be replaced whenever.

@lioncash lioncash merged commit b073db5 into dolphin-emu:master Sep 2, 2017
@spycrab spycrab deleted the qt_fix_older branch September 2, 2017 02:27
@leoetlino leoetlino modified the milestone: Qt Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ligfx ligfx ligfx approved these changes

@lioncash lioncash lioncash approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
Qt
4 participants
@spycrab @lioncash @ligfx @leoetlino