Parse IMGTEC's GL_VERSION string format #6006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lioncash
reviewed
Sep 2, 2017
| // Ends up as "109.4850625" - "1.9" being the branch, "4850625" being the build's change ID | ||
| // The change ID only makes sense to compare within a branch | ||
| driver = DriverDetails::DRIVER_QUALCOMM; | ||
| double glVersion; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| driver = DriverDetails::DRIVER_QUALCOMM; | ||
| double glVersion; | ||
| int major, minor, change; | ||
| double changeScale = 10000000; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| } | ||
| else | ||
| { | ||
| version += (double)change / changeScale; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
JonnyH
force-pushed
the
WIP/parse-imgtec-gl_version-string
branch
from
8130135
to
8cdb5e0
Compare
lioncash
reviewed
Sep 2, 2017
| driver = DriverDetails::DRIVER_QUALCOMM; | ||
| double gl_version; | ||
| int major, minor, change; | ||
| constexpr double changeScale = 10000000; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
JonnyH
force-pushed
the
WIP/parse-imgtec-gl_version-string
branch
from
8cdb5e0
to
06effe9
Compare
ImgTec's driver uses a major.minor@changeID versioning system This is packed into a double so "1.9@4850625" becomes "109.4850625" The next release brnach is expected to be 1.10, hence the need for 2 digits for the branch minor. The changeID should be unique for each build, but is shared over all branches, so only makes sense to compare withing a branch. It's likely branch 'major' versions will be used for major hardware revisions, and the drivers for both maintained in parallel. Thus it may not make sense to compare versions between different major verisons - if/when this happens we can hook up a DriverDetails::Family as needed.
Now we correctly parse ImgTec's GL_VERSION string we can actually use the BugInfo's version stuff correctly here
JonnyH
force-pushed
the
WIP/parse-imgtec-gl_version-string
branch
from
06effe9
to
658a4a6
Compare
|
LGTM |
lioncash
approved these changes
Sep 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ImgTec's driver uses a major.minor@changeID versioning system
This is packed into a double so "1.9@4850625" becomes "109.4850625"
The next release brnach is expected to be 1.10, hence the need for 2
digits for the branch minor.
The changeID should be unique for each build, but is shared over all
branches, so only makes sense to compare withing a branch.
It's likely branch 'major' versions will be used for major hardware
revisions, and the drivers for both maintained in parallel. Thus it
may not make sense to compare versions between different major
verisons - if/when this happens we can hook up a DriverDetails::Family
as needed.