Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AsyncShaderCompiler: Make WorkItem-derived class constructors explicit #6009

Merged
merged 2 commits into from Sep 3, 2017
Merged

AsyncShaderCompiler: Make WorkItem-derived class constructors explicit #6009

merged 2 commits into from Sep 3, 2017

Conversation

lioncash
Copy link
Member

@lioncash lioncash commented Sep 2, 2017

Prevents implicit conversions

@lioncash
OGL/ProgramShaderCache: Remove unnecessary virtual keyword
5059332 
This is superfluous, considering the override keyword is present.
@lioncash
VideoBackends: Add the explicit keyword to WorkItem-derived class con…
2d45204 
…structors

Prevents implicit conversions
stenzek
stenzek approved these changes Sep 3, 2017
View reviewed changes
Copy link
Contributor

@stenzek stenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stenzek stenzek merged commit 005d0b3 into dolphin-emu:master Sep 3, 2017
@lioncash lioncash deleted the async branch September 3, 2017 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stenzek stenzek stenzek approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@lioncash @stenzek