Android: various cleanups in UI code #6086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is handled by gradle, we don't need a separate strings.xml for debug.
FRAGMENT_ID wasn't actually the fragment's ID (that's misleading, and sounds like the tag). It's actually the layout resource ID. There's no point in making that a static constant.
lioncash
reviewed
Sep 26, 2017
| @@ -59,6 +59,7 @@ | |||
| private FrameLayout mFrameEmulation; | |||
| private LinearLayout mMenuLayout; | |||
|
|
|||
| private enum MenuType {SAVE, LOAD} | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Fix the hack of using the layout resource ID as a save/load ID, and instead use a proper enum.
Prefixing everything with a constant packagename is not needed for internal keys, and just adds complexity. Rename ARGUMENT_ prefix to ARG_ to match (most) of the rest of the codebase. Restrict visiblity of above as much as possible.
|
Can you take another look at this? |
Helios747
approved these changes
Sep 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor cleanup for Android UI code.