TraversalServer: use C++'s <chrono> and <random> #6157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ligfx
force-pushed
the
traversalserverchronorandom
branch
2 times, most recently
from
9c6c2d5
to
1894c7c
Compare
riking
suggested changes
Nov 1, 2017
| bytesLeft = sizeof(bytes); | ||
| } | ||
| memcpy(output, bytes + (bytesLeft -= size), size); | ||
| static std::independent_bits_engine<std::default_random_engine, sizeof(unsigned char) * 8, |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
merryhime
reviewed
Nov 2, 2017
| bytesLeft = sizeof(bytes); | ||
| } | ||
| memcpy(output, bytes + (bytesLeft -= size), size); | ||
| static std::independent_bits_engine<std::default_random_engine, sizeof(unsigned char) * 8, |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ligfx
force-pushed
the
traversalserverchronorandom
branch
2 times, most recently
from
ee4ec73
to
e715501
Compare
lioncash
reviewed
Nov 2, 2017
| { | ||
| ssize_t rv = read(urandomFd, bytes, sizeof(bytes)); | ||
| if (rv != sizeof(bytes)) | ||
| for (; begin != end; ++begin) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
|
||
| { | ||
| static RandomDeviceSeedSequence s_seed_seq; | ||
| static std::independent_bits_engine<std::default_random_engine, sizeof(unsigned char) * 8, |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ligfx
force-pushed
the
traversalserverchronorandom
branch
from
e715501
to
550c05b
Compare
ligfx
force-pushed
the
traversalserverchronorandom
branch
from
550c05b
to
9669705
Compare
|
We use mbed TLS for random number generation now, so that commit is no longer needed. |
|
Rebased PR: #8091 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simpler than
gettimeofdayand reading/dev/urandom, and cross-platform to boot!