Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements and important fix for NAND checks #6161

Merged
merged 3 commits into from Nov 2, 2017
Merged

Improvements and important fix for NAND checks #6161

merged 3 commits into from Nov 2, 2017

Conversation

leoetlino
Copy link
Member

@leoetlino leoetlino commented Nov 2, 2017 •
edited

  • Unify the NAND check and repair functions to make it clear what actions will be taken for every issue that is found. This fixes an issue which could cause the repair function to incorrectly delete data for all disc titles
  • Change the NAND check popup message to inform the user that launching affected titles can also fix the issues.

@leoetlino
WiiUtils: Unify the check and repair functions
1cd4be1 
Makes it clearer what actions will be taken for every issue
that is found.
lioncash
lioncash reviewed Nov 2, 2017
View reviewed changes
Source/Core/DolphinWX/FrameTools.cpp Outdated
@@ -1338,6 +1338,7 @@ void CFrame::OnCheckNAND(wxCommandEvent&)
StringFromFormat("%016" PRIx64, title_id);
message += "\n";
}
message += _("\nLaunching these titles may also fix the issues.");

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@leoetlino
UI: Tweak the NAND check popup message
71d4c47 
Inform the user that re-launching titles can also fix the issues.
@leoetlino
WiiUtils: Ignore missing contents for DLC titles
f2eee36 
It is not possible to tell whether DLC contents are supposed to be
present on the NAND or not, because they're treated as "optional".
So this commit changes the NAND check to not consider missing
contents for DLC titles as an issue.
@leoetlino leoetlino changed the title Minor improvements to NAND checks Improvements and important fix for NAND checks Nov 2, 2017
@Helios747 Helios747 merged commit 423cde2 into dolphin-emu:master Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lioncash lioncash lioncash left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@leoetlino @lioncash @Helios747