-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Replace current file browser #6282
Conversation
This was a regression from the time we introrduced the Platform enums.
ef9300b
to
60c8043
Compare
Do you know how the external storages are mounted for the native app? Does Android uses fuse now? And as this is a visual change, may I ask for screenshots? ;) |
@degasus forgive my lack of knowledge since this is the first time I hear of Fuse and the links might be not relative but from a quick look it seems Android has this for ages: form what I understood, FUSE should allow the native code to access external storage without any extra effort which is what happened in this PR since it is working on Shield TV without touching any native code. |
// Configure initial directory by specifying a String. | ||
// You could specify a String like "/storage/emulated/0/", but that can | ||
// dangerous. Always use Android's API calls to get paths to the SD-card or | ||
// internal memory. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
1. Allow users to pick games dircetory from external storage. 2. Better UX experince to distinguish between selecting a directory or a game. The later is needed when we implement change disk for android.
60c8043
to
409ae4c
Compare
@@ -74,6 +78,16 @@ | |||
android:exported="false"> | |||
</provider> | |||
|
|||
<provider | |||
android:name="android.support.v4.content.FileProvider" | |||
android:authorities="${applicationId}.filesprovider" |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
a game. The later is needed when we implement change disk for android.
This PR & PR#6270 will make introducing the change disc feature for the Android client easier. Should be my next thing to do.