Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Replace current file browser #6282

Merged
merged 2 commits into from
Jan 10, 2018

Conversation

mahdihijazi
Copy link
Contributor

  1. Allow users to pick games dircetory from external storgae.
  2. Better UX experince to distinguish between selecting a directory or
    a game. The later is needed when we implement change disk for android.
  3. fix refreshing the games list after adding a directory in mobile devices.

This PR & PR#6270 will make introducing the change disc feature for the Android client easier. Should be my next thing to do.

This was a regression from the time we introrduced the Platform enums.
@degasus
Copy link
Member

degasus commented Jan 5, 2018

Do you know how the external storages are mounted for the native app? Does Android uses fuse now?

And as this is a visual change, may I ask for screenshots? ;)

@mahdihijazi
Copy link
Contributor Author

mahdihijazi commented Jan 5, 2018

@degasus forgive my lack of knowledge since this is the first time I hear of Fuse and the links might be not relative but from a quick look it seems Android has this for ages:
https://www.quora.com/Does-the-Android-kernel-support-the-FUSE-API-natively
https://www.xda-developers.com/diving-into-sdcardfs-how-googles-fuse-replacement-will-reduce-io-overhead/

form what I understood, FUSE should allow the native code to access external storage without any extra effort which is what happened in this PR since it is working on Shield TV without touching any native code.

Mobile
Mobile

TV
TV

External Storage Access
External Storage Access

// Configure initial directory by specifying a String.
// You could specify a String like "/storage/emulated/0/", but that can
// dangerous. Always use Android's API calls to get paths to the SD-card or
// internal memory.

This comment was marked as off-topic.

1. Allow users to pick games dircetory from external storage.
2. Better UX experince to distinguish between selecting a directory or
a game. The later is needed when we implement change disk for android.
@degasus degasus merged commit a1467f0 into dolphin-emu:master Jan 10, 2018
@@ -74,6 +78,16 @@
android:exported="false">
</provider>

<provider
android:name="android.support.v4.content.FileProvider"
android:authorities="${applicationId}.filesprovider"

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

@mahdihijazi mahdihijazi deleted the replace_file_browser branch July 20, 2018 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants