New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Replace current file browser #6282

Merged
merged 2 commits into from Jan 10, 2018

Conversation

3 participants
@mahdihijazi
Contributor

mahdihijazi commented Jan 3, 2018

  1. Allow users to pick games dircetory from external storgae.
  2. Better UX experince to distinguish between selecting a directory or
    a game. The later is needed when we implement change disk for android.
  3. fix refreshing the games list after adding a directory in mobile devices.

This PR & PR#6270 will make introducing the change disc feature for the Android client easier. Should be my next thing to do.

[Android] Fix refreshing the games list after adding a directory
This was a regression from the time we introrduced the Platform enums.
@degasus

This comment has been minimized.

Show comment
Hide comment
@degasus

degasus Jan 5, 2018

Member

Do you know how the external storages are mounted for the native app? Does Android uses fuse now?

And as this is a visual change, may I ask for screenshots? ;)

Member

degasus commented Jan 5, 2018

Do you know how the external storages are mounted for the native app? Does Android uses fuse now?

And as this is a visual change, may I ask for screenshots? ;)

@mahdihijazi

This comment has been minimized.

Show comment
Hide comment
@mahdihijazi

mahdihijazi Jan 5, 2018

Contributor

@degasus forgive my lack of knowledge since this is the first time I hear of Fuse and the links might be not relative but from a quick look it seems Android has this for ages:
https://www.quora.com/Does-the-Android-kernel-support-the-FUSE-API-natively
https://www.xda-developers.com/diving-into-sdcardfs-how-googles-fuse-replacement-will-reduce-io-overhead/

form what I understood, FUSE should allow the native code to access external storage without any extra effort which is what happened in this PR since it is working on Shield TV without touching any native code.

Mobile
Mobile

TV
TV

External Storage Access
External Storage Access

Contributor

mahdihijazi commented Jan 5, 2018

@degasus forgive my lack of knowledge since this is the first time I hear of Fuse and the links might be not relative but from a quick look it seems Android has this for ages:
https://www.quora.com/Does-the-Android-kernel-support-the-FUSE-API-natively
https://www.xda-developers.com/diving-into-sdcardfs-how-googles-fuse-replacement-will-reduce-io-overhead/

form what I understood, FUSE should allow the native code to access external storage without any extra effort which is what happened in this PR since it is working on Shield TV without touching any native code.

Mobile
Mobile

TV
TV

External Storage Access
External Storage Access

[Android] Replace current file browser
1. Allow users to pick games dircetory from external storage.
2. Better UX experince to distinguish between selecting a directory or
a game. The later is needed when we implement change disk for android.

@degasus degasus merged commit a1467f0 into dolphin-emu:master Jan 10, 2018

10 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
@@ -74,6 +78,16 @@
android:exported="false">
</provider>
<provider
android:name="android.support.v4.content.FileProvider"
android:authorities="${applicationId}.filesprovider"

This comment has been minimized.

@degasus

degasus Feb 20, 2018

Member

I think this breaks debug builds. They have a postfix on the application id. But we may just drop this postfix instead...

@degasus

degasus Feb 20, 2018

Member

I think this breaks debug builds. They have a postfix on the application id. But we may just drop this postfix instead...

This comment has been minimized.

@mahdihijazi

mahdihijazi Feb 20, 2018

Contributor

hmm..probably you are right but I wonder why I didn't see it breaking during the development 🤔

@mahdihijazi

mahdihijazi Feb 20, 2018

Contributor

hmm..probably you are right but I wonder why I didn't see it breaking during the development 🤔

This comment has been minimized.

@mahdihijazi

mahdihijazi Feb 20, 2018

Contributor

Did you receive any bug report regarding this? What make you come back and check it :)

@mahdihijazi

mahdihijazi Feb 20, 2018

Contributor

Did you receive any bug report regarding this? What make you come back and check it :)

@mahdihijazi mahdihijazi deleted the mahdihijazi:replace_file_browser branch Jul 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment