Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DriverDetails: Disable primitive restart on Vulkan with Mali driver #6435

Merged
merged 2 commits into from
Mar 14, 2018
Merged

DriverDetails: Disable primitive restart on Vulkan with Mali driver #6435

merged 2 commits into from
Mar 14, 2018

Conversation

stenzek
Copy link
Contributor

@stenzek stenzek commented Mar 13, 2018

According to @degasus this causes corrupted rendering.

I've pulled in the vendor detection commit from #6067, as I'm not sure if the vendor ID alone is sufficient for detecting Mali GPUs. Although I pulled a few reports from vulkan.gpuinfo.org, and they all share the same vendorID.

This is needed to differentiate between the open-source Mesa drivers and
their binary counterparts for Intel and AMD.
@hrydgard
Copy link
Contributor

hrydgard commented Mar 13, 2018

Vendor ID is supposed to be enough, that's the whole idea of it :) Well, until ARM releases another line of GPUs that aren't called Mali, I guess. Though looking at the RADV situation in your code, hm... maybe it's not that simple.

@degasus degasus merged commit b6ef069 into dolphin-emu:master Mar 14, 2018
@brujo5
Copy link

brujo5 commented Mar 14, 2018

Fixed broken textures and black screen in galaxy S6. Thx
Finally I can play dolphin emu with Vulkan api very fast

@stenzek stenzek deleted the mali-primitive-restart branch February 11, 2019 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants