Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interpreter_FPUtils: Get rid of a pointer cast #6515

Merged
merged 1 commit into from Mar 25, 2018
Merged

Interpreter_FPUtils: Get rid of a pointer cast #6515

merged 1 commit into from Mar 25, 2018

Conversation

lioncash
Copy link
Member

This is undefined behavior according to the standard. We can just use the built in means of retrieving a quiet NaN.

@riking
Copy link
Contributor

riking commented Mar 24, 2018

Why not:

/* static */ constexpr double PPC_NAN = std::numeric_limits<double>::quiet_NaN();

Keeps the readability.

@lioncash
Interpreter_FPUtils: Get rid of a pointer cast
27611d5 
This is undefined behavior according to the standard. We can just use
the built in means of retrieving a quiet NaN.
@leoetlino leoetlino merged commit 5c83e18 into dolphin-emu:master Mar 25, 2018
@lioncash lioncash deleted the cast branch March 25, 2018 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BhaaLseN BhaaLseN BhaaLseN approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@lioncash @riking @BhaaLseN @leoetlino