Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interpreter_Integer: Correct precedence of overflow check in nego #6520

Merged
merged 1 commit into from Mar 25, 2018
Merged

Interpreter_Integer: Correct precedence of overflow check in nego #6520

merged 1 commit into from Mar 25, 2018

Commits on Mar 25, 2018

  1. Interpreter_Integer: Correct precedence of overflow check in nego 

    The overflow check needs to occur before the condition register update
due to the fact that the summary overflow (SO) bit is used in the
updating of the condition register. If we set any overflow bits after
updating the CR, then we can potentially incorrectly report that an
overflow did not happen (in the case the SO bit wasn't set previously).
    @lioncash
    lioncash committed Mar 25, 2018
    Copy the full SHA
    89df65a View commit details
    Browse the repository at this point in the history