GCPadStatus: coalescing magic numbers into consts #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -103,12 +103,12 @@ void GCPad::GetInput(GCPadStatus* const pad) | |||
|
|
|||
| // sticks | |||
| m_main_stick->GetState(&x, &y); | |||
| pad->stickX = 0x80 + (x * 0x7F); | |||
| pad->stickY = 0x80 + (y * 0x7F); | |||
| pad->stickX = GCPadStatus::MAIN_STICK_CENTER_X + (x * GCPadStatus::MAIN_STICK_MAX_MAGNITUDE_X); | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
@booto: This comment grants you the permission to merge this pull request whenever you think it is ready. After addressing the remaining comments, click this link to merge. LGTM, I'm not sure about RADIUS vs. MAX_MAGNITUDE, will let you decide that. @dolphin-emu-bot allowmerge |
|
Thanks for doing this <3 |
dolphin-emu-bot
added a commit
that referenced
this pull request
Jul 21, 2014
GCPadStatus: coalescing magic numbers into consts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eliminates duplicated magic numbers from a few different files and makes them a named constant members of the structure that uses them.