DolphinQt2/CMakeLists: Use the target_* equivalents of add_definitions and include_directories #6598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and include_directories add_definitions and include_directories don't operate on a by-target basis, they act on a by-directory basis (i.e. if we defined two targets, A and B, in this CMakeLists file, add_definitions would add the definitions to the COMPILE_DEFINITIONS directory property which both A and B would implicitly use). The same idea applies to include_directories, only it appends to the INCLUDE_DIRECTORIES directory property. Instead, specify these on the target to keep scope as narrow as possible.
leoetlino
approved these changes
Apr 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add_definitionsandinclude_directoriesdon't operate on a by-target basis, they act on a by-directory basis (i.e. if we defined two targets, A and B, in this CMakeLists file,add_definitionswould add the definitions to theCOMPILE_DEFINITIONSdirectory property which both A and B would implicitly use).The same idea applies to
include_directories, only it appends to theINCLUDE_DIRECTORIESdirectory property.Instead, specify these on the target to keep scope as narrow as possible.