docs: Update the GameCube DSP User's Manual #6641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
rebase please |
Dolphin source had a lot more info than the tables, so it makes sense to include them in the manual
some did not reflect the correct PC increments, other had their registers mixed up. LSNM was misspelled as LSMN.
|
Done. |
lioncash
approved these changes
Jul 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #6623, opened for review anyways.
I also intend to update the PDF when review is complete; so please don't merge it right away.It's also an option for @lioncash to include it with his PR to reduce the number of PDF updates (even though the filesize is quite small, it is still part of history and needs to be transferred on clones).
I've had those changes lying around for a few years (actually, since 2010 according to the file date?!), but back then didn't want to commit it without review (which would've gone straight to trunk on googlecode); and editing the PDF directly felt dirty as well...
This mostly updates the docs to reflect our findings and results from testing/RE, as well as a few (presumably) copy/paste fixes inside opcode operations (wrong regs, incorrect PC advances).
Commits are primarily for review, I can squash them if preferred.