IOS/STM: Reset the event hook at the correct time #6642
Merged
+2
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BhaaLseN
reviewed
Apr 13, 2018
Source/Core/Core/IOS/STM/STM.h
Outdated
| @@ -55,7 +55,7 @@ class STMEventHook final : public Device | |||
| { | |||
| public: | |||
| using Device::Device; | |||
| IPCCommandResult Close(u32 fd) override; | |||
| ~STMEventHook(); | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Just re-disassembled STM and found out I have made a mistake when I changed STM stuff back in 2016. I accidentally made STM reset the event hook on close when it should have been done in the destructor (i.e. when IOS gets reset on console). Verified in IDA that STM just `IOS_ResourceReply(request, IOS_OK)` without ever resetting the hook.
lioncash
approved these changes
Apr 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just re-disassembled STM and found out I have made a mistake when
I changed STM stuff back in 2016.
I accidentally made STM reset the event hook on close when it should
have been done in the destructor (i.e. when IOS gets reset on console).
Verified in IDA that STM just
IOS_ResourceReply(request, IOS_OK)without ever resetting the hook.