Remove audio frame limit. #667
Conversation
|
I have no comment about the actual change because I know nothing about it but I like when commit messages explains the changes so I know why removing the frame limit is a good thing. |
|
Audio frame limit's purpose was to workaround fullspeed pops and crackling in async audio. Now that Audio is synced to the framerate in all circumstances, there's no reason for it anymore, and it can cause confusion among users. Hence, this PR. And I agree that this should be in the description. |
| @@ -631,7 +631,7 @@ void VideoThrottle() | |||
| bool ShouldSkipFrame(int skipped) | |||
| { | |||
| const u32 TargetFPS = (SConfig::GetInstance().m_Framelimit > 1) | |||
| ? SConfig::GetInstance().m_Framelimit * 5 | |||
| ? (SConfig::GetInstance().m_Framelimit - 1) * 5 | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
This is going to wreck that harvest moon game where the audio is running at 33 fps on HLE and 31 fps on LLE. |
|
There's also other audio issues that I've seen people claim audio framelimit fixes (possibly involving the wide variety of frequencies near 48kHz that PC soundcards actually process instead of exactly 48kHz; check out higan's config for this stuff). It'd be best to figure out the cause of these and the Harvest Moon issues and fix them properly before removing the audio framelimit. ...Then again, 90% of the people currently using it probably shouldn't be using it, so we might as well remove it now. |
|
@JMC47 How would it wreck it? (Don't know if this was an issue in the past or not) |
|
The only way to get the audio to sound half decent is to set frame-limit to audio and let it run at 33 fps/66 vps in HLE, and 31 fps, 62vps in LLE. |
|
Wouldn't that be indicative of an underlying emulation issue though? Audio is one of the things I know least about Dolphin, so if I'm wrong, just tell me. |
|
Oh yeah, it's definitely some kind of bug in Dolphin. I'm just saying perhaps it should be looked into before we go taking away the only work-around for the issue. I don't want a case where people are using older builds like when the sonic unleashed hack was removed with no replacement. |
|
You know what? Nevermind. framelimit to audio no longer fixes this anyway, it got broken worse somewhere along the lines and I didn't notice. LGTM |
|
"fixing" one game isn't a reason to keep it anyway. |
|
From what I can tell, audio frame limit was broken (further) in the Rewrite DTK merge, it would probably need a major rework to start working again. No reason not to remove it. |
|
Looks good to me. |
|
@RachelBryk Please fix the description of the PR to actually explain why this feature should be removed. Not everyone wants to read the whole thread just to figure out why this is even happening. |
It serves no purpose and causes bugs and confusion for users.
|
Audio Framelimit is really messed up in the very latest builds, sticking to the wrong framerates even in most games. So, I think it should be removed asap. |
|
It would have been nice if the reasoning for this had been presented better, but since @JMC47 says that it's rather broken than useful I guess this change is for the better. |
|
hi, I have problems since this commit, I was playing metroid prime 2: echoes and since this commit I can't play because of the very very clipping sound, it's very annoying. I adjust fps for PAL version (50fps), HLE, LLE but nothing helps. With audio frame limit sound is good in this game with no clipping for me. Anyway only have noticed in this game, others games seems to be ok. |
|
Could you make an issue report with audio dumps. If the game has problems with audio, then we'd gladly look at it. Make sure you do not have the vbeam speedhack on while testing. http://code.google.com/p/dolphin-emu/issues/list Audio frame-limit should never be needed for a game to have working audio. |
|
Thanks for your quick reply. |
It serves no purpose and causes bugs and confusion for users.