Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qt/NetPlayDialog: Multiple improvements #6805

Merged
merged 7 commits into from
May 11, 2018
Merged

Qt/NetPlayDialog: Multiple improvements #6805

merged 7 commits into from
May 11, 2018

Conversation

spycrab
Copy link
Contributor

@spycrab spycrab commented May 10, 2018 •
edited

Before:
Before
After:
After

Helios747
Helios747 reviewed May 10, 2018
View reviewed changes
Copy link
Contributor

@Helios747 Helios747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the build on ubuntu builder and it LGTM

lioncash
lioncash reviewed May 10, 2018
View reviewed changes
Source/Core/DolphinQt2/NetPlay/NetPlayDialog.h Outdated
@@ -106,4 +109,5 @@ class NetPlayDialog : public QDialog, public NetPlayUI
GameListModel* m_game_list_model = nullptr;
bool m_use_traversal = false;
bool m_is_copy_button_retry = false;
int m_buffer_size;

This comment was marked as off-topic.

Sign in to view

@leoetlino leoetlino merged commit 5071973 into dolphin-emu:master May 11, 2018
@spycrab spycrab deleted the qt_netplay branch May 11, 2018 10:28
@spycrab spycrab mentioned this pull request May 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lioncash lioncash lioncash left review comments

@Helios747 Helios747 Helios747 left review comments

@leoetlino leoetlino leoetlino approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@spycrab @lioncash @leoetlino @Helios747