DSPHLE/UCodes: Replace unnecessary virtual keywords with override #6871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given these HLE classes inherit from a common base with a virtual destructor, override is more appropriate here, as virtual propagates to these destructors anyway. This is also safer. If the base class' destructor is ever made non-virtual, then these classes will cause a compilation error if they aren't taken into account, as they'd be overriding a non-virtual function (the destructor).
|
(build failure isn't directly related to the changes made, especially given the regular Windows builder passed) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given these HLE classes inherit from a common base with a virtual destructor, override is more appropriate here, as virtual propagates to these destructors anyway.
This is also safer. If the base class' destructor is ever made non-virtual, then these classes will cause a compilation error if they aren't taken into account, as they'd be overriding a non-virtual function (the destructor).