Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Fix case in FindPugixml resulting in false negative #7021

Merged
merged 1 commit into from
May 30, 2018

Conversation

akien-mga
Copy link
Contributor

As mentioned in GH-6652.

If you prefer it lowercase, an alternative is to make everything lowercase (including pugixml_FOUND in CMakeLists.txt - and maybe Findpugixml.cmake, not sure).

@Tilka
Copy link
Member

Tilka commented May 30, 2018

All official references to pugixml I can find are lowercase, including the name in its pkgconfig/pugixml.pc file.

@akien-mga
Copy link
Contributor Author

All official references to pugixml I can find are lowercase, including the name in its pkgconfig/pugixml.pc file.

That's right. The most common usage I've seen in CMake find modules is to use PascalCase or try to follow the upstream "pretty" name, which often has a case different to its library/headers, e.g. FindPhysFS.cmake (with find_package(PhysFS) and PhysFS_FOUND).

But here you're correct that pugixml is always written lowercase, even on upstream's website and its pkgconfig file, so I'll switch everything to lowercase.

@akien-mga
Copy link
Contributor Author

Updated to all lowercase (including Findpugixml.cmake).

@Tilka Tilka merged commit 9bf5ad1 into dolphin-emu:master May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants