Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Remove using namespace statements from the Jit and Interpreter headers #714

Merged
merged 1 commit into from Aug 2, 2014

Conversation

lioncash
Copy link
Member

@lioncash lioncash commented Aug 2, 2014

Moves them to the cpp files so we don't have these sort of things drift via header.

@lioncash lioncash changed the title Core: Remove using statements from the Jit and Interpreter headers Core: Remove using namespace statements from the Jit and Interpreter headers Aug 2, 2014
@Tilka
Copy link
Member

Tilka commented Aug 2, 2014

lgtm

@BhaaLseN
Copy link
Member

BhaaLseN commented Aug 2, 2014

Should probably have been in the code style PR, but whats our general rule for using using namespace NS; vs. using NS::Member;?
Removing them in once place but adding them elsewhere doesn't really make much sense at first sight. And its pretty unlikely that we have duplicate defines somewhere (that may conflict with global ones).

@Tilka
Copy link
Member

Tilka commented Aug 2, 2014

@BhaaLseN

Removing them in once place but adding them elsewhere doesn't really make much sense at first sight.

It's just that you don't want them in headers where they can end up all over the place.

@BhaaLseN
Copy link
Member

BhaaLseN commented Aug 2, 2014

Duh, point taken. I tend to get focused on the actual changes so I don't really mind what kind of files they're in.

delroth added a commit that referenced this pull request Aug 2, 2014
Core: Remove using namespace statements from the Jit and Interpreter headers
@delroth delroth merged commit 8f768e5 into dolphin-emu:master Aug 2, 2014
@lioncash lioncash deleted the gen branch January 25, 2017 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants