Interpreter: Remove an unnecessary cast in Trace() #7229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PowerPCState's cr_val member is an array of u64s, so we can just use the correct printf macro specifier within cinttypes. This also avoids truncation on operating systems that use an LLP64 data model (like Windows), where long is actually 32 bits in size, not 64-bit, which could result in wonky values being printed, should Trace ever be used on it.
BhaaLseN
approved these changes
Jul 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PowerPCState's
cr_valmember is an array ofu64s, so we can just use the correct printf macro specifier within<cinttypes>. This also avoids truncation on operating systems that use an LLP64 data model (likeWindows), where long is actually 32 bits in size, not 64-bit, which could result in wonky values being printed, should Trace ever be used on it.
Alternatively, if Trace() is a vestigial part of the interpreter, we can just remove it entirely.