SI: Add 16bit accessors for SI IO buffer #7331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lioncash
reviewed
Aug 15, 2018
| m_code->SHR(64, R(m_dst_reg), Imm8(48)); | ||
| break; | ||
| case 32: | ||
| m_code->SHR(64, R(m_dst_reg), Imm8(32)); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
BhaaLseN
reviewed
Aug 15, 2018
Source/Core/Core/HW/SI/SI.cpp
Outdated
| mmio->Register(address, MMIO::DirectRead<u32>((u32*)&s_si_buffer[i]), | ||
| MMIO::DirectWrite<u32>((u32*)&s_si_buffer[i])); | ||
| mmio->Register(address, MMIO::DirectSwapRead<u32>((u32*)&s_si_buffer[i]), | ||
| MMIO::DirectSwapWrite<u32>((u32*)&s_si_buffer[i])); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
booto
changed the title
|
Works with all of our devices. Tested Keyboard, Dancemat (lol), Standard Controller, Steering Wheel, and Bongos. |
booto
changed the title
Dolphin has traditionally treated the SI IO buffer (128 bytes) as a set of 32 little endian u32s. This works out fine if you only ever read/write using aligned 32bit accesses. Different sized accesses or misaligned reads will mess it up. Byte swapping reads/writes will fix this up, but all the SI devices that use the SI IO buffer need to be adjusted.
Helios747
approved these changes
Sep 14, 2018
lioncash
approved these changes
Sep 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding some extra accessors to the SI IO buffer.
Dolphin has traditionally treated the SI IO buffer (128 bytes) as a set of
32 little endian u32s. This works out fine if you only ever read/write
using aligned 32bit accesses. Different sized accesses or misaligned reads
will mess it up. Byte swapping reads/writes will fix this up, but all the
SI devices that use the SI IO buffer need to be fixed.