VS2017: update windows 10 sdk from 10.0.15063.0 to 10.0.17134.0 (for minizip) #7595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
...and we forgot to update the README.md again :/ |
|
No, README.md and the rest of Dolphin is already at 10.0.17134.0. Only minizip needed to be updated. |
|
Oh, great, nevermind then :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Dolphin requires Windows 10 SDK 10.0.17134.0 to be compiled but minizip was using another version,
It's fixes with this PR,
Tested with visual studio pro 2017 (15.9.2) and Windows 10 SDK, version 1803 (10.0.17134.0)
-Yohann