Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DolphinQt: Avoid leaking the GameListModel instance to gracefully shutdown the GameTracker and prevent a crash on exit #7714

Merged
merged 7 commits into from
Nov 18, 2020
Merged

DolphinQt: Avoid leaking the GameListModel instance to gracefully shutdown the GameTracker and prevent a crash on exit #7714

merged 7 commits into from
Nov 18, 2020

Commits on Oct 1, 2020

  1. Removed all references to GameListModel from the Settings component.

    @cristian64
    cristian64 committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    0d02e70 View commit details
    Browse the repository at this point in the history

  2. GameListModel instance ownership transferred back to the GameList ins… 

    …tance. The GameListModel instance will be passed as a constructor parameter where needed.
    @cristian64
    cristian64 committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    5b75702 View commit details
    Browse the repository at this point in the history

  3. Extended WorkQueueThread class with Clear(), Cancel() and IsCancelled().

    @cristian64
    cristian64 committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    213610e View commit details
    Browse the repository at this point in the history

  4. Ensured that GameTracker's internal worker thread is flushed on exit … 

    …to avoid crashes when accessing stale, already-destroyed data, and to favor responsiveness.
    @cristian64
    cristian64 committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    dc7b926 View commit details
    Browse the repository at this point in the history

  5. Avoid using unnecessary RunOnObject() calls in GameTracker's worker t… 

    …hread to prevent deadlocks on shutdown.
    @cristian64
    cristian64 committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    bada677 View commit details
    Browse the repository at this point in the history

  6. **Refresh** and **Purge Game List Cache** now correctly enabled/disab… 

    …led as notified by GameListRefreshRequested and GameListRefreshCompleted.
    @cristian64
    cristian64 committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    4ca9246 View commit details
    Browse the repository at this point in the history

  7. Improved responsiveness when refreshing game list.

    @cristian64
    cristian64 committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    ee13e6e View commit details
    Browse the repository at this point in the history