Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placed ampersands and asterisks against type name #795

Merged

Conversation

crozhon
Copy link
Contributor

@crozhon crozhon commented Aug 13, 2014

Placed ampersands and asterisks against type name as described in the style guide. Also placed asterisks against the type name and removed the space for casts.

Ex. (int*) instead of (int *)

@archshift
Copy link
Contributor

LGTM

@lioncash
Copy link
Member

You missed a few pointers (around where you change the wxStaticBitmap
pointers).

I'd comment directly on the line but all Android apps for Github are awful
and don't allow this.
On Aug 13, 2014 5:48 PM, "Charles Rozhon" notifications@github.com wrote:

Placed ampersands and asterisks against type name as described in the
style guide. Also placed asterisks against the type name and removed the
space for casts.

Ex. (int*) instead of (int *)

You can merge this Pull Request by running

git pull https://github.com/ChuckRozhon/dolphin correct_pointer_style_tasinputdlg

Or view, comment on, or merge it at:

#795
Commit Summary

  • Placed ampersands and asterisks against type name

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#795.

@crozhon
Copy link
Contributor Author

crozhon commented Aug 13, 2014

Are you referring to wxTextCtrl *textX, *textY? I didn't change these or any others that were multiple definitions on the same line. It wasn't referenced in the style guide at all, so I just went for consistency.

@lioncash
Copy link
Member

Oh OK. No worries then.
On Aug 13, 2014 6:59 PM, "Charles Rozhon" notifications@github.com wrote:

Are you referring to wxTextCtrl *textX, *textY? I didn't change these or
any others that were multiple definitions on the same line. It wasn't
referenced in the style guide at all, so I just went for consistency.


Reply to this email directly or view it on GitHub
#795 (comment).

lioncash added a commit that referenced this pull request Aug 15, 2014
…utdlg

Placed ampersands and asterisks against type name
@lioncash lioncash merged commit f6dd2ff into dolphin-emu:master Aug 15, 2014
@crozhon crozhon deleted the correct_pointer_style_tasinputdlg branch August 15, 2014 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants