Added debug log option in GUI for debug builds #7994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dolphin-emu-bot rebuild |
|
I'd rather have the debug option be invisible when you're using a release build. (That's how DolphinWX worked, right?) |
|
I can't decide if I'd want it disabled or invisible. Either way could cause different confusion. I guess invisible would cause less confusion. ..Unless we had a tooltip that said DEBUG level requires dolphin to built in Debug mode. |
BhaaLseN
reviewed
Apr 13, 2019
|
I made the button invisible & took @BhaaLseN's advice. |
stenzek
reviewed
Apr 21, 2019
Also gets rid of two unnecessary casts.
|
Rebased the branch, squashed the commits and added a commit to replace the magic numbers with LogTypes::LOG_LEVELS. Anyone want to review this again? The rest looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't see an option in the debugger UI to keep debug logs on. This adds it, and marks 'Debug' as disabled if the DEBUG level log isn't compiled in (like in release builds).