Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Qt/Mapping: Visual GCPad configuration #8063

Open
wants to merge 1 commit into
base: master
from

Conversation

2 participants
@spycrab
Copy link
Contributor

commented May 1, 2019

Very WIP, a code review might not be worth the bother at this point

Windows build can be downloaded here (Might not always be up-to-date)

Screenshot

This PR introduces the option to map inputs to the GameCube controller using a more visually pleasing interface which utilizes QtQuick.

Usage

Simply map inputs to a part of a controller by clicking the boxes next to them. If you press a mapped key, the controller will light up the pressed button / move the sticks.

FAQ

A: Will this replace the normal mapping dialog?
Q: No, it's in a separate tab, see the screenshot.

A: Why QtQuick?
Q: While possible with QWidgets it would not be fun to implement and somewhat inflexible. It is also likely that we will be moving more components to QtQuick as time goes on.

TODO

  • Fix cut-off SVGs
  • Windows support
    • Update vcxproj file
    • Add resource file somehow
    • Add QtQuick to qt-ext-win
    • Add required QML modules to qt-ext-win
  • Get rid of dependency on QtGraphicalEffects
  • Cleanly separate digital and analog trigger input
  • Turn Stick.qml into bearable code
  • Fix overlapping input boxes
  • Move code out of GCMappingWidget to make a generic QtQuick MappingWidget
  • Minify SVGs

@spycrab spycrab added the WIP label May 1, 2019

@spycrab

This comment has been minimized.

Copy link
Contributor Author

commented May 1, 2019

Our Debian / Ubuntu buildbots are missing qtdeclarative5-dev at the moment, which is required to build this PR.

@spycrab spycrab force-pushed the spycrab:qt_visual branch 2 times, most recently from 2b23910 to ec0951d May 1, 2019

@jordan-woyak

This comment has been minimized.

Copy link
Member

commented May 1, 2019

The stick gates seem to be ten sided instead of eight sided? 😛

@spycrab spycrab force-pushed the spycrab:qt_visual branch 2 times, most recently from c2560f8 to 0ef21c6 May 1, 2019

@spycrab spycrab force-pushed the spycrab:qt_visual branch from 0ef21c6 to e6bbf1f May 1, 2019

@spycrab

This comment has been minimized.

Copy link
Contributor Author

commented May 1, 2019

@jordan-woyak Heh, wouldn't have caught that. It's an octagon now.

@spycrab

This comment has been minimized.

Copy link
Contributor Author

commented May 1, 2019

The QML code is now baked into the program at compile time. At least under non-Windows platforms.

@spycrab

This comment has been minimized.

Copy link
Contributor Author

commented May 2, 2019

The increase in total program size will probably be < 10M for all additions AFAICT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.