Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoCommon: Implement passive stereoscopic 3D #8069

Merged
merged 1 commit into from May 12, 2019

Conversation

3 participants
@iwubcode
Copy link
Contributor

commented May 2, 2019

Passive 3d support was suggested years ago when stereoscopic 3d was initially created but never implemented. Users have since then created workarounds using external apps and shaders. After pulling my passive 3d monitor out of the closet, I decided to finally implement it!

@@ -324,7 +331,8 @@ void EnhancementsWidget::AddDescriptions()
"Selects the stereoscopic 3D mode. Stereoscopy allows a better feeling "
"of depth if the necessary hardware is present.\n\nSide-by-Side and Top-and-Bottom are "
"used by most 3D TVs.\nAnaglyph is used for Red-Cyan colored glasses.\nHDMI 3D is "
"used when the monitor supports 3D display resolutions.\n\nHeavily decreases "
"used when the monitor supports 3D display resolutions.\nPassive is another type of 3D "
"used by some TVs\n\nHeavily decreases "

This comment has been minimized.

Copy link
@Techjar

Techjar May 2, 2019

Contributor

Missing period.

@iwubcode iwubcode force-pushed the iwubcode:passive_support branch from a53b022 to 256eec5 May 2, 2019

@iwubcode iwubcode force-pushed the iwubcode:passive_support branch from 256eec5 to c513bb5 May 5, 2019

@stenzek
Copy link
Contributor

left a comment

LGTM

@stenzek stenzek merged commit 707266a into dolphin-emu:master May 12, 2019

10 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.