Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MoltenVK: Update to Vulkan SDK version 1.1.108.0 #8110

Merged
merged 1 commit into from
Jun 24, 2019
Merged

MoltenVK: Update to Vulkan SDK version 1.1.108.0 #8110

merged 1 commit into from
Jun 24, 2019

Conversation

stenzek
Copy link
Contributor

@stenzek stenzek commented May 22, 2019

Apparently this fixes a memory leak, see https://dolp.in/i11738/7

Untested, I just pulled the latest SDK.

@pizuz
Copy link

pizuz commented May 22, 2019

You might want to skip this version. 1.1.106.0 has two separate crashes with Dolphin. Both have been fixed, but those fixes haven‘t made it into LunarG‘s build, yet. The crash can be reproduced with the Buildbot build from your branch, just try to run any game.

Issues:
KhronosGroup/MoltenVK#573
KhronosGroup/MoltenVK#584

@Degerz
Copy link

Degerz commented Jun 3, 2019

@stenzek An unrelated heads up for you but Khronos has just released their fragment shader interlock extension for Vulkan. Once MoltenVK supports the extension, you'll finally be able to add ROVs/interlocks for programmable blending thus being able to further improve the accuracy of GPU emulation!

@Dubai2014
Copy link

Dubai2014 commented Jun 9, 2019

Can anybody explain what i have to do to geht Dolphin with Vulkan Support to work on my MacBook Pro?
OS: Mojave 10.14.4
I tried it with Version 5.0-10411.
Thanks for your help

@MayImilae
Copy link
Contributor

@Dubai2014 This is not a support forum. For help, please use our forums: https://forums.dolphin-emu.org/

@pizuz
Copy link

pizuz commented Jun 14, 2019

Vulkan SDK 1.1.108.0 is about to be released and the MoltenVK build to be shipped with it will fix the crashes I mentioned.

EDIT: It‘s out now.

@stenzek stenzek changed the title MoltenVK: Update to Vulkan SDK version 1.1.106.0 MoltenVK: Update to Vulkan SDK version 1.1.108.0 Jun 24, 2019
@stenzek
Copy link
Contributor Author

stenzek commented Jun 24, 2019

Switched to 1.1.108.0. If someone could test/confirm this is working I'll go ahead and merge.

@pizuz
Copy link

pizuz commented Jun 24, 2019

I can confirm that the updated build from this branch works without crashing.

I can also confirm that the memory leak is no longer present.

@stenzek
Copy link
Contributor Author

stenzek commented Jun 24, 2019

Thanks for confirming :)

@stenzek stenzek merged commit d69fb80 into dolphin-emu:master Jun 24, 2019
@stenzek stenzek deleted the update-moltenvk branch June 24, 2019 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants