VolumeVerifier: Performance improvements #8299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| StringFromFormat(Common::GetStringT("Content %08x is corrupt.").c_str(), content.id)); | ||
| } | ||
| m_content_future = std::async(std::launch::async, [this, read_succeeded, content] { | ||
| if (!read_succeeded || !m_volume.CheckContentIntegrity(content, m_data, m_ticket)) |
There was a problem hiding this comment.
read_succeededcan possibly be moved outside the future so it only executes conditionally.- Other
m_volumemethods are protected bym_volume_mutex, I assume it's not needed here?
There was a problem hiding this comment.
- The reason I didn't do that was because then I'd need to duplicate the call to
AddProblem(one inside the lambda and one outside the lambda). A read failing is a rare event, and a WAD file usually doesn't have more than 10 contents or so anyway, so this won't have any noticeable performance impact. - It's only needed if the volume is reading data from the disk, which is not the case here since we pass in a vector with the data to verify. It's the same if you look at the two different calls to
CheckBlockIntegrity.
lioncash
reviewed
Aug 6, 2019
JosJuice
force-pushed
the
volumeverifier-performance
branch
from
e8eee6b
to
34fb608
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the tests I've done, these changes make verification 50% to 100% faster.