Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WiimoteEmu: IMU pointing behavior improvements and code cleanup. #8545

Merged
merged 6 commits into from Jan 15, 2020

Conversation

@jordan-woyak
Copy link
Member

jordan-woyak commented Jan 4, 2020

  • Replaced IMU cursor's hacky Euler angle math with 3x3 matrices.
  • Enabled "Recenter" button for both yaw and pitch adjustment (previously just yaw was done).
  • Added a couple of matrix functions and other minor cleanups.

Pointing now behaves when the controller is in odd orientations (e.g. tilted, sideways, upside-down).
There are fewer branches and special cases in the math and I think it's more readable.

@jordan-woyak jordan-woyak force-pushed the jordan-woyak:imu-cursor-centering branch from d6afa99 to 7870485 Jan 4, 2020
@jordan-woyak jordan-woyak force-pushed the jordan-woyak:imu-cursor-centering branch 2 times, most recently from 935cb81 to dba5fe0 Jan 4, 2020
@JMC47

This comment has been minimized.

Copy link
Contributor

JMC47 commented Jan 6, 2020

Seems to help a lot if you're holding the Emulated Remote in really weird directions.

@jordan-woyak jordan-woyak force-pushed the jordan-woyak:imu-cursor-centering branch from dba5fe0 to 0aacf3a Jan 9, 2020
@delroth delroth merged commit 1ac3264 into dolphin-emu:master Jan 15, 2020
10 checks passed
10 checks passed
default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
@jordan-woyak jordan-woyak deleted the jordan-woyak:imu-cursor-centering branch Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.