Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WiimoteEmu: IMU pointing behavior improvements and code cleanup. #8545

Merged
merged 6 commits into from
Jan 15, 2020

Conversation

jordan-woyak
Copy link
Member

  • Replaced IMU cursor's hacky Euler angle math with 3x3 matrices.
  • Enabled "Recenter" button for both yaw and pitch adjustment (previously just yaw was done).
  • Added a couple of matrix functions and other minor cleanups.

Pointing now behaves when the controller is in odd orientations (e.g. tilted, sideways, upside-down).
There are fewer branches and special cases in the math and I think it's more readable.

@jordan-woyak jordan-woyak force-pushed the imu-cursor-centering branch 2 times, most recently from 935cb81 to dba5fe0 Compare January 5, 2020 16:40
@JMC47
Copy link
Contributor

JMC47 commented Jan 6, 2020

Seems to help a lot if you're holding the Emulated Remote in really weird directions.

@delroth delroth merged commit 1ac3264 into dolphin-emu:master Jan 15, 2020
@jordan-woyak jordan-woyak deleted the imu-cursor-centering branch January 15, 2020 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants