Add headers required by XAudio2_7 to externals. #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shuffle2: This comment grants you the permission to merge this pull request whenever you think it is ready. After addressing the remaining comments, click this link to merge. Not a big fan from the licensing standpoint, but meh. Other projects seem to be doing the same thing, and these headers are part of a freely available SDK. I'm really not sure how licensing works here, usually I would try to stay on the safe side, but here both sides seem pretty safe. LGTM, @dolphin-emu-bot allowmerge. |
This makes all builds' audio compatible with downlevel Windows and removes the need for developers to install the June 2010 DirectX SDK.
shuffle2
added a commit
that referenced
this pull request
Aug 23, 2014
Add headers required by XAudio2_7 to externals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes all builds audio compatible with downlevel Windows and removes
the need for developers to install the June 2010 DirectX SDK.