Replace usage of std::result_of with std::invoke_result #8841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
std::result_of is deprecated in C++17, and removed in C++20. Microsoft has gone ahead with the removal as of Visual Studio 16.6.0, so before this change our code is broken there.
lioncash
approved these changes
Jun 1, 2020
|
You might want to update this issue if you fix all the cases: |
|
Yeah we're just waiting on the Qt update. |
|
Just a heads up, if you update externals to QT 5.14.2 (currently it's still on 5.14.1) it should build fine again - I managed to build it with cmake on VS 2019 16.6.1 while using building against my local copy of QT 5.14.2 - likely the standard VS Project will work fine too if using 5.14.2 (didnt't try it though) |
|
Yeah that's exactly what we're going to do. Changing your local VS project to C++17 also works as an easier temporary solution, since this only happens because we use C++latest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::result_ofis deprecated in C++17, and removed in C++20. Microsoft has gone ahead with the removal as of Visual Studio 16.6.0, so before this change our code is broken there.Externals/Qt also needs to be updated to the latest version to fully fix the build.